Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP notice for undefined theme support arg for service_worker #2070

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fix PHP notice for undefined theme support arg for service_worker #2070

merged 1 commit into from
Apr 5, 2019

Conversation

westonruter
Copy link
Member

Amends #1261. Fixes:

Notice: Undefined index: service_worker in /app/wp-content/plugins/amp/includes/class-amp-service-worker.php on line 48

@westonruter westonruter added this to the v1.1 milestone Apr 5, 2019
@westonruter westonruter requested a review from amedina April 5, 2019 04:27
@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 5, 2019
amedina
amedina approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@westonruter westonruter merged commit b963bb8 into develop Apr 5, 2019
@westonruter westonruter deleted the fix/service-worker-undefined-index branch April 5, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @amedina @googlebot